| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In case the server is set up for multi-factor authentication we could
be have to query several things from the user like password, a key
passphrase, their mother's maiden name etc. It doesn't make a big
difference during an initial connection, but it butchers the
reconnection process: it can retrieve the answer of the user to the
first question (e.g. their password), but it fails to retrieve the
second one (e.g. the key passphrase). So the user would be forced to
reenter the answer for the second question upon each reconnection.
The reason for this is the passwdserver's desig (see DESIGN [1]):
Each query for AuthInfo with the openPassDlg() has an secNr number
associated with it. If it's smaller than the one of the one stored for
the privious request, than the one from the cache will be returned
automagically, if it's bigger the dialog will be prompted to the user.
Each call to openPassDlg() advances s_seqNr to the last value reported
by the passwdserver. So the first call will return the cached value and
subsequent calls will actually display the dialog to the user (assuming
authentication with the cached data failed).
But in case of multi-factor auth we have to query user for several
independent values. And we want to try to retrieve each one of those
from the cache. So we have to get a bit hacky and manually manipulate
the SlaveBase::s_seqNr value.
[1]: https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/src/branch/master/tdeio/kpasswdserver/DESIGN
Signed-off-by: Alexander Golubev <[email protected]>
(cherry picked from commit 95b18e63382c4f0013c4eb2473d04f6020a84b7a)
|
|
|
|
|
| |
Signed-off-by: Alexander Golubev <[email protected]>
(cherry picked from commit 4d88b3edddc46ab56e773c4c73cd29b3292b3181)
|
|
|
|
|
| |
Signed-off-by: Alexander Golubev <[email protected]>
(cherry picked from commit ee73349644fdf2a3a2ac122d7f930f84b00bcdba)
|
|
|
|
|
| |
Signed-off-by: Alexander Golubev <[email protected]>
(cherry picked from commit f8f0b8815ca821ad6764149a915122f8b2f0bf8b)
|
|
|
|
|
|
|
|
| |
This could be useful in case the destructor will be called before
openConnection()
Signed-off-by: Alexander Golubev <[email protected]>
(cherry picked from commit 21ce69f338efb0636e9eef0e7405825b5dd7c0b0)
|
|
|
|
|
| |
Signed-off-by: Alexander Golubev <[email protected]>
(cherry picked from commit 009382772da4cb5a56749ea67ed29c09658a4f69)
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We should always pass to the openPassDlg() exactly the same username
otherwise it may result in incorrect caching of passwords especially in
case if the username is changed by the user.
Also don't allow username change in case it was passed to setHost()
(i.e. it was specified in the URL like e.g. sftp://username@host/).
In such a case after changing it'd be impossible to properly cache it.
Signed-off-by: Alexander Golubev <[email protected]>
(cherry picked from commit 581d266ae6f085317b4247b2d1ddbc12c8fa09fb)
|
|
|
|
|
|
|
|
|
|
| |
- Move authentication methods into separate functions so it would be
easier to correctly handle error after those and select which should
be called in which order.
- A lot of minor improvements along the way
Signed-off-by: Alexander Golubev <[email protected]>
(cherry picked from commit 2756ae762fefc3fe86463174866674a987856d89)
|
|
|
|
|
|
|
|
|
|
|
| |
This will help kpasswdserver not to confuse different user's answers to
different questions.
Also avoid passing/returning TDE::AuthInfo for kb-interactive auth as it
isn't really necessary when we don't manually caching passwords anymore.
Signed-off-by: Alexander Golubev <[email protected]>
(cherry picked from commit d316ff14bdcc6c7e402276cba2a15c1ac8bb5278)
|
|
|
|
|
|
|
|
| |
All password caching we need actually already autmagically
done by openPassDlg().
Signed-off-by: Alexander Golubev <[email protected]>
(cherry picked from commit a19610bb735faf89fcd27c6885bf81e53c9b2d7a)
|
|
|
|
|
|
|
|
|
| |
There were a couple of missing closeConnection() calls after connection
errors. The probably haven't caused any major bugs, but use scope guards
to be on the safe side.
Signed-off-by: Alexander Golubev <[email protected]>
(cherry picked from commit 9c0a0ce976549c1849eecb497be2d8bdf49d7aa5)
|
|
|
|
|
| |
Signed-off-by: Alexander Golubev <[email protected]>
(cherry picked from commit 75349be43e1b4ced52502f98316148a7b55c1352)
|
|
|
|
|
|
|
| |
As it allocated via malloc() rather than new.
Signed-off-by: Alexander Golubev <[email protected]>
(cherry picked from commit 688544193fb40241435b07f83135d91ad708c6df)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Several enhancements to public key authentication and some other stuff:
- Fix passphrase entry for encrypted keys (was either hanging up or
segfaulting)
- Use scope guard idiom for cleanup calls for more reliable cleanup in
case of errors
- Add normal prompt for public key's passphrase entry dialog
- Correctly differentiate passphrase to password when cached (yes they
are getting cached regardless of keepPassword, at least for some
duration of time)
- Centrilize AuthInfo initialization and some rejig of it
kbd-interactive authentification
Signed-off-by: Alexander Golubev <[email protected]>
(cherry picked from commit b91e2203891ce7ef627a241ea05c3f11180fcfc1)
|
|
|
|
|
|
|
|
|
| |
This is a partial fix to the sftp ioslave. Subsequent commits will fix
other issues.
Closes: https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/issues/443
Signed-off-by: Alexander Golubev <[email protected]>
(cherry picked from commit a1fa8a79bbd7f6385d312cce709768944506d960)
|
|
|
|
|
| |
Signed-off-by: Michele Calgaro <[email protected]>
(cherry picked from commit 2d7d2122cf33aa713cebef95981305039c798003)
|
|
|
|
|
| |
Signed-off-by: Michele Calgaro <[email protected]>
(cherry picked from commit 0d9263f836b892b03742c494bd236d57b63ebb19)
|
|
|
|
|
| |
Signed-off-by: Michele Calgaro <[email protected]>
(cherry picked from commit 4484e51ca69d3080fac8692a7a203c49dc47ab1e)
|
|
|
|
|
| |
Signed-off-by: Michele Calgaro <[email protected]>
(cherry picked from commit a4241b7911d2e0b36edfb02f616b8b282050c0ec)
|
|
|
|
|
| |
Signed-off-by: Michele Calgaro <[email protected]>
(cherry picked from commit c4a6487c827add9382001ff1892b8fb3bfa94682)
|
|
|
|
|
| |
Signed-off-by: Alexander Golubev <[email protected]>
(cherry picked from commit f2dbf5b9035e9a4861b7d0ad348f4f86c4caba03)
|
|
|
|
|
| |
Signed-off-by: Michele Calgaro <[email protected]>
(cherry picked from commit 82c1dbe490f7afcb5b48fdfb8748bde249bcf4f7)
|
|
|
|
|
| |
Signed-off-by: Michele Calgaro <[email protected]>
(cherry picked from commit 36f2e08fd382c7042fbd3c8e7708f3ba1b9c9bd7)
|
|
|
|
|
| |
Signed-off-by: Michele Calgaro <[email protected]>
(cherry picked from commit b965cbac5b21345e9dfc768a7e4f660ffa4aa72f)
|
|
|
|
|
|
|
| |
QIODevice with TQ* version
Signed-off-by: Michele Calgaro <[email protected]>
(cherry picked from commit 33c7d159890b81da8f44ee330a349e3abd553bec)
|
|
|
|
|
| |
Signed-off-by: Michele Calgaro <[email protected]>
(cherry picked from commit 75a74bedaee5c942c8d3cf8d353b33f10cf460b2)
|
|
|
|
|
| |
Signed-off-by: Michele Calgaro <[email protected]>
(cherry picked from commit 014f6d2586905e03681aa6fb9a85c2c8190e53f4)
|
|
|
|
|
| |
Signed-off-by: Michele Calgaro <[email protected]>
(cherry picked from commit 7bc43c68b3c095631628e1fb691242315687d15b)
|
|
|
|
|
| |
Signed-off-by: Michele Calgaro <[email protected]>
(cherry picked from commit 814bf5fc4f403c13b0d8274c7f13fbef183c5c84)
|
|
|
|
|
|
|
| |
merging of tqtinterface with tqt3.
Signed-off-by: Michele Calgaro <[email protected]>
(cherry picked from commit 22625693f124aae09863f4d33e30b625a96c3557)
|
|
|
|
|
| |
Signed-off-by: Denis Kozadaev <[email protected]>
(cherry picked from commit 4d58a4ea8daf1a3cb91b7d8c6e574dd6f5bdb685)
|
|
|
|
| |
Signed-off-by: Michele Calgaro <[email protected]>
|
|
|
|
|
|
| |
removable drives and CD/DVD disks.
Signed-off-by: Michele Calgaro <[email protected]>
|
|
|
|
|
| |
Signed-off-by: Mavridis Philippe <[email protected]>
Signed-off-by: Slávek Banko <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
| |
For details see PR #279.
Portions of code borrowed from KDE5 SFTP ioslave:
Source: https://invent.kde.org/network/kio-extras/-/blob/master/sftp/kio_sftp.cpp
Licence: LGPLv2 or later
Signed-off-by: Mavridis Philippe <[email protected]>
|
|
|
|
|
|
|
|
|
| |
Source: https://github.com/sandsmark/kde2-kio-sftp-kde4
Licence: GPLv2 or later
This resolves issue #276.
Signed-off-by: Mavridis Philippe <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
| |
"Only store password in KWallet if the user asked for it"
https://invent.kde.org/network/kio-extras/-/commit/d813cef3cecdec9af1532a40d677a203ff979145
Author: David Faure
Licence: GPLv2
This mitigates CVE-2020-12755.
Signed-off-by: Mavridis Philippe <[email protected]>
|
|
|
|
| |
Signed-off-by: Michele Calgaro <[email protected]>
|
|
|
|
| |
Signed-off-by: Michele Calgaro <[email protected]>
|
|
|
|
|
|
|
|
| |
mount/unmout/lock/unlock/ejct media devices.
This ensures a consistent media device status also with complex
partition structures and LUKS encryption.
Signed-off-by: Michele Calgaro <[email protected]>
|
|
|
|
| |
Signed-off-by: Michele Calgaro <[email protected]>
|
|
|
|
| |
Signed-off-by: Michele Calgaro <[email protected]>
|
|
|
|
| |
Signed-off-by: Michele Calgaro <[email protected]>
|
|
|
|
| |
Signed-off-by: Michele Calgaro <[email protected]>
|
|
|
|
| |
Signed-off-by: Michele Calgaro <[email protected]>
|
|
|
|
| |
Signed-off-by: Michele Calgaro <[email protected]>
|
|
|
|
|
|
| |
special cases.
Signed-off-by: Slávek Banko <[email protected]>
|
|
|
|
| |
Signed-off-by: Michele Calgaro <[email protected]>
|
|
|
|
| |
Signed-off-by: Michele Calgaro <[email protected]>
|
|
|
|
| |
Signed-off-by: Slávek Banko <[email protected]>
|