TDE
/
gwenview
6
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Labels Milestones

Replace Qt with TQt #21

Merged
MicheleC merged 1 commits from replace/qt_tqt into master 1 year ago
Conversation 1 Commits 1 Files Changed 5
MicheleC commented 1 year ago
Owner

As per title.

As per title.
MicheleC added this to the R14.1.2 release milestone 1 year ago
MicheleC added 1 commit 1 year ago
1aa3ce5f69
Replace Qt with TQt 
Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
MicheleC requested review from Core 1 year ago
MicheleC requested review from Owners 1 year ago
Fat-Zer approved these changes 1 year ago
src/gvcore/xpm.cpp
@ -1,5 +1,5 @@
/* This file is based on qt-3.3.2/src/qimage.cpp , plus it includes
* a fix from qt-bugs@ issue #49934. Original copyright follows.
/* This file is based on tqt-3.3.2/src/qimage.cpp , plus it includes
* a fix from tqt-bugs@ issue #49934. Original copyright follows.
Fat-Zer commented 1 year ago
Collaborator

this one probably should stay as-is

this one probably should stay as-is
MicheleC commented 1 year ago
Poster
Owner

Good catch

Good catch
MicheleC marked this conversation as resolved
src/gvcore/xpm.h
@ -1,4 +1,4 @@
/* This file is based on qt-3.3.2/src/qimage.cpp . Original
/* This file is based on tqt-3.3.2/src/qimage.cpp . Original
Fat-Zer commented 1 year ago
Collaborator

same as above, it references a specific version of qt...

same as above, it references a specific version of qt...
MicheleC marked this conversation as resolved
MicheleC force-pushed replace/qt_tqt from 1aa3ce5f69 to 32098c8e56 1 year ago
MicheleC commented 1 year ago
Poster
Owner

PR updated. Please double check again, not sure you had approved it by mistake since you were pointing out required changes (should have pressed the "red" button, not the "green" one 😄 )

PR updated. Please double check again, not sure you had approved it by mistake since you were pointing out required changes (should have pressed the "red" button, not the "green" one 😄 )
MicheleC requested review from Fat-Zer 1 year ago
SlavekB approved these changes 1 year ago
SlavekB left a comment
Owner

It looks good.

It looks good.
MicheleC merged commit 32098c8e56 into master 1 year ago
MicheleC deleted branch replace/qt_tqt 1 year ago

Reviewers

Fat-Zer was requested for review 1 year ago
SlavekB approved these changes 1 year ago
TDE/Core was requested for review 1 year ago
The pull request has been merged as 32098c8e56.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Fat-Zer
SlavekB
TDE/Core
Labels
Apply labels
Clear labels   
GE/need-info

General - need additional info from contributor   
PR/keep-branch

Pull request - do not delete branch after merging   
PR/not-ok

Pull request - need fixing   
PR/rfc

Pull request - request for comments   
PR/update-trans

Pull request - update to translation files needed   
PR/wip

Pull request - work in progress   
RS/R14.0.x

Related to R14.0.x series   
RS/R14.1.x

Related to R14.1.x series   
SL/critical

Severity level - critical   
SL/major

Severity level - major   
SL/minor

Severity level - minor   
SL/normal

Severity level - normal   
SL/regression

Severity level - regression from previous version   
SL/trivial

Severity level - trivial   
SL/wishlist

Severity level - wishlist request   
ST/duplicate

Status - duplicate of another issue   
ST/invalid

Status - invalid report   
ST/notourproblem

Status - not our problem   
ST/rejected

Status - rejected   
ST/wontfix

Status - won't fix   
ST/worksforme

Status - works for me, unable to reproduce
No Label
GE/need-info
PR/keep-branch
PR/not-ok
PR/rfc
PR/update-trans
PR/wip
RS/R14.0.x
RS/R14.1.x
SL/critical
SL/major
SL/minor
SL/normal
SL/regression
SL/trivial
SL/wishlist
ST/duplicate
ST/invalid
ST/notourproblem
ST/rejected
ST/wontfix
ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.1.2 release
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TDE/gwenview#21
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'replace/qt_tqt'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes