Drop dummy development test for vertical tab widget #28

Merged
MicheleC merged 1 commits from drop/dummy-test into master 1 year ago
Owner

The test is just a simple file doing pretty much nothing other than opening a window with a vertical tab widget. It does not do any gwenview application testing, so it does not really belong in the source code.

The test is just a simple file doing pretty much nothing other than opening a window with a vertical tab widget. It does not do any gwenview application testing, so it does not really belong in the source code.
MicheleC added this to the R14.1.2 release milestone 1 year ago
MicheleC added 1 commit 1 year ago
686ac45321
Drop dummy development test for vertical tab widget
Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
MicheleC requested review from Fat-Zer 1 year ago
MicheleC requested review from Core 1 year ago
MicheleC requested review from Owners 1 year ago
SlavekB approved these changes 1 year ago
SlavekB left a comment
Owner

Yes, it is not a program functionality test, so there is no reason to keep it in code.

Yes, it is not a program functionality test, so there is no reason to keep it in code.
Fat-Zer approved these changes 1 year ago
Fat-Zer left a comment
Collaborator

probably it's fine, it's highly unlikely that anybody will ever use it... On the other hand, the non-automated tests like this in tdelibs AFAIR still present and get built by make check...

probably it's fine, it's highly unlikely that anybody will ever use it... On the other hand, the non-automated tests like this in tdelibs AFAIR still present and get built by `make check`...
Poster
Owner

probably it's fine, it's highly unlikely that anybody will ever use it... On the other hand, the non-automated tests like this in tdelibs AFAIR still present and get built by make check...

The difference here is that it is not really a test related to gwenview, which is why we are removing it. In src/imageutils there is another non automated test and that remains since it is actually doing some real work.

> probably it's fine, it's highly unlikely that anybody will ever use it... On the other hand, the non-automated tests like this in tdelibs AFAIR still present and get built by `make check`... The difference here is that it is not really a test related to gwenview, which is why we are removing it. In src/imageutils there is another non automated test and that remains since it is actually doing some real work.
MicheleC merged commit 686ac45321 into master 1 year ago
MicheleC deleted branch drop/dummy-test 1 year ago

Reviewers

SlavekB approved these changes 1 year ago
Fat-Zer approved these changes 1 year ago
TDE/Core was requested for review 1 year ago
The pull request has been merged as 686ac45321.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TDE/gwenview#28
Loading…
There is no content yet.