TDE
/
knemo
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Labels Milestones

cmake conversion #1

Merged
SlavekB merged 1 commits from feat/cmakeConv into master 6 years ago
Conversation 2 Commits 1 Files Changed 1
Ghost commented 6 years ago
There is no content yet.
Ghost added the
PR/wip
 label 6 years ago
SlavekB commented 6 years ago
Owner

Please, for translations, instead of using CMakeLists.txt in each individual folder, use solutions such as is in knetstats. Not only is it easier, but mainly because newly created translations will be automatically processed without the need to create CMakeLists.txt for each new translation.

Please, for translations, instead of using CMakeLists.txt in each individual folder, use solutions such as is in [knetstats](../knetstats/src/branch/master/translations/CMakeLists.txt). Not only is it easier, but mainly because newly created translations will be automatically processed without the need to create CMakeLists.txt for each new translation.
Ghost changed title from WIP: cmake conversion to cmake conversion 6 years ago
Ghost added
PR/rfc
 and removed
PR/wip
 labels 6 years ago
SlavekB commented 6 years ago
Owner

I made a little change. Programs ifconfig, route and iwconfig are searched for, instead of specifying fixed paths. Next I added the usual UI includes patch.

I made a little change. Programs ifconfig, route and iwconfig are searched for, instead of specifying fixed paths. Next I added the usual UI includes patch.
SlavekB removed the
PR/rfc
 label 6 years ago
SlavekB approved these changes 6 years ago
SlavekB left a comment
Owner

Tested, it looks good.

Tested, it looks good.
SlavekB closed this pull request 6 years ago
SlavekB deleted branch feat/cmakeConv 6 years ago
SlavekB added this to the R14.0.7 release milestone 6 years ago
The pull request has been merged as a775e20ccd.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels   
GE/need-info

General - need additional info from contributor   
PR/keep-branch

Pull request - do not delete branch after merging   
PR/not-ok

Pull request - need fixing   
PR/rfc

Pull request - request for comments   
PR/update-trans

Pull request - update to translation files needed   
PR/wip

Pull request - work in progress   
RS/R14.0.x

Related to R14.0.x series   
RS/R14.1.x

Related to R14.1.x series   
SL/critical

Severity level - critical   
SL/major

Severity level - major   
SL/minor

Severity level - minor   
SL/normal

Severity level - normal   
SL/regression

Severity level - regression from previous version   
SL/trivial

Severity level - trivial   
SL/wishlist

Severity level - wishlist request   
ST/duplicate

Status - duplicate of another issue   
ST/invalid

Status - invalid report   
ST/notourproblem

Status - not our problem   
ST/rejected

Status - rejected   
ST/wontfix

Status - won't fix   
ST/worksforme

Status - works for me, unable to reproduce
No Label
GE/need-info
PR/keep-branch
PR/not-ok
PR/rfc
PR/update-trans
PR/wip
RS/R14.0.x
RS/R14.1.x
SL/critical
SL/major
SL/minor
SL/normal
SL/regression
SL/trivial
SL/wishlist
ST/duplicate
ST/invalid
ST/notourproblem
ST/rejected
ST/wontfix
ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.7 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TDE/knemo#1
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/cmakeConv'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes