TDE
/
knemo
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Labels Milestones

Change default backend from Nettools to Sys. #4

Merged
MicheleC merged 1 commits from feat/sys_backend into master 4 years ago
Conversation 2 Commits 1 Files Changed 5
Ghost commented 4 years ago

The Sys backend works contrary to the Nettools backend so I'm changing the default backend.

It is a tweak (or a pita one may say...) because the net-tools should be working, but at least Knemo will work from the "get-go" from now on.

The Sys backend works contrary to the Nettools backend so I'm changing the default backend. It is a tweak (or a pita one may say...) because the net-tools should be working, but at least Knemo will work from the "get-go" from now on.
Ghost added the
PR/wip
 label 4 years ago
Ghost added 1 commit 4 years ago
7e5ea16f1a
Change default backend from Nettools to Sys. 
Signed-off-by: gregory guy <gregory-tde@laposte.net>
MicheleC commented 4 years ago
Owner

Looks good and I think it is a good idea to have "sys" as default backend. Will work in many systems out of the box.

Looks good and I think it is a good idea to have "sys" as default backend. Will work in many systems out of the box.
Ghost force-pushed feat/sys_backend from 7e5ea16f1a to 0bbb027ba5 4 years ago
Ghost changed title from WIP:Change default backend from Nettools to Sys. to Change default backend from Nettools to Sys. 4 years ago
Ghost removed the
PR/wip
 label 4 years ago
Ghost force-pushed feat/sys_backend from 0bbb027ba5 to 3ee43d19a0 4 years ago
Ghost force-pushed feat/sys_backend from 3ee43d19a0 to 32e1e2a090 4 years ago
MicheleC requested changes 4 years ago
MicheleC left a comment
Owner

Needs removal of CMakeLists.txt changes, which belong to a different PR (#5).
Other than that, it is good to go, as was commit 7e5ea16f1a.

Needs removal of CMakeLists.txt changes, which belong to a different PR (#5). Other than that, it is good to go, as was commit 7e5ea16f1a.
CMakeLists.txt Outdated
@ -42,3 +42,3 @@
##### optional stuff
option( WITH_ALL_OPTIONS "Enable all optional support" OFF )
option( WITH_ALL_OPTIONS "Enable all optional support" OFF )
MicheleC commented 4 years ago
Owner

Hi Greg,
I guess when the new forced-pushed commit was done, this CMakeLists.txt stuff slipt through by mistake. It was not there in the original commit (7e5ea16f1a)
Could you clean up this commit again if you don't mind? Then I will merge.

Hi Greg, I guess when the new forced-pushed commit was done, this CMakeLists.txt stuff slipt through by mistake. It was not there in the original commit (7e5ea16f1a) Could you clean up this commit again if you don't mind? Then I will merge.
Ghost commented 4 years ago
Poster

yes my bad I pushed in the wrong branch by mistake, but unless I've been missing something, this does not add or remove anything It is just some indentation changes, furthermore I'll be using this indent in my next PR because CMakeLists.txt files are more readable that way.

yes my bad I pushed in the wrong branch by mistake, but unless I've been missing something, this does not add or remove anything It is just some indentation changes, furthermore I'll be using this indent in my next PR because CMakeLists.txt files are more readable that way.
MicheleC commented 4 years ago
Owner

Correct, there is no issues with that. Just that is was also used in PR #5. As long as you rebase #5 after this PR is merged, then no problem.
I will merge as is then.

Correct, there is no issues with that. Just that is was also used in PR #5. As long as you rebase #5 after this PR is merged, then no problem. I will merge as is then.
MicheleC marked this conversation as resolved
Ghost force-pushed feat/sys_backend from 32e1e2a090 to a9e1d50df4 4 years ago
MicheleC approved these changes 4 years ago
MicheleC merged commit a9e1d50df4 into master 4 years ago
MicheleC deleted branch feat/sys_backend 4 years ago
MicheleC added this to the R14.0.11 release milestone 4 years ago
MicheleC commented 4 years ago
Owner

Thanks Greg!

Thanks Greg!

Reviewers

MicheleC approved these changes 4 years ago
The pull request has been merged as a9e1d50df4.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
MicheleC
Labels
Apply labels
Clear labels   
GE/need-info

General - need additional info from contributor   
PR/keep-branch

Pull request - do not delete branch after merging   
PR/not-ok

Pull request - need fixing   
PR/rfc

Pull request - request for comments   
PR/update-trans

Pull request - update to translation files needed   
PR/wip

Pull request - work in progress   
RS/R14.0.x

Related to R14.0.x series   
RS/R14.1.x

Related to R14.1.x series   
SL/critical

Severity level - critical   
SL/major

Severity level - major   
SL/minor

Severity level - minor   
SL/normal

Severity level - normal   
SL/regression

Severity level - regression from previous version   
SL/trivial

Severity level - trivial   
SL/wishlist

Severity level - wishlist request   
ST/duplicate

Status - duplicate of another issue   
ST/invalid

Status - invalid report   
ST/notourproblem

Status - not our problem   
ST/rejected

Status - rejected   
ST/wontfix

Status - won't fix   
ST/worksforme

Status - works for me, unable to reproduce
No Label
GE/need-info
PR/keep-branch
PR/not-ok
PR/rfc
PR/update-trans
PR/wip
RS/R14.0.x
RS/R14.1.x
SL/critical
SL/major
SL/minor
SL/normal
SL/regression
SL/trivial
SL/wishlist
ST/duplicate
ST/invalid
ST/notourproblem
ST/rejected
ST/wontfix
ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.11 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TDE/knemo#4
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/sys_backend'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes