Labels Milestones

WIP: Ctrl+[Movement Keys] changes virtual desktop #8

Closed

blu.256 wants to merge 4 commits from issue/2 into master

pull from: issue/2

merge into: TDE:master

TDE:master

TDE:r14.1.x

TDE:r14.0.x

TDE:issue/10

Conversation 4 Commits 4 Files Changed 4

blu.256 commented 4 years ago

Collaborator

Seems to wors, but:

• Highlight is not removed from virtual desktop widget under mouse.

Seems to wors, but: * Highlight is not removed from virtual desktop widget under mouse.

blu.256 added 2 commits 4 years ago

a857ed1c14

Added appropriate event handler in KomposeFullscreenWidget. ...

Signed-off-by: Mavridis Philippe <mavridisf@gmail.com>

cc13befa92

Copied focusNeighbourChild with slight modifications. ...

Charmingly, this seems to work nicely.

Signed-off-by: Mavridis Philippe <mavridisf@gmail.com>

blu.256 added 1 commit 4 years ago

d5db6c5c25

Implemented special activation functions. ...

They combine some traits of both {enter,leave}Event and focus{In,Out}Event.

Signed-off-by: Mavridis Philippe <mavridisf@gmail.com>

blu.256 added 1 commit 4 years ago

b5e39bb95f

Added special setActive() and setInactive() functions. ...

They handle both focus and highlight, which seems logical.

This fixes most annoying bugs with desktop switching.

Signed-off-by: Mavridis Philippe <mavridisf@gmail.com>

blu.256 added 1 commit 4 years ago

24c6b74209

Storing active virtual desktop in a variable is more reliable ...

as a widget can lose its focus.

Signed-off-by: Mavridis Philippe <mavridisf@gmail.com>

blu.256 closed this pull request 4 years ago

blu.256 added the

PR/keep-branch

ST/duplicate

labels 4 years ago

MicheleC commented 4 years ago

Owner

Just for info and documentation, am I right to assume this PR has been replaced by PR #9 and hence it has been closed?

Just for info and documentation, am I right to assume this PR has been replaced by PR #9 and hence it has been closed?

blu.256 commented 4 years ago

Poster

Collaborator

This is actually a duplicate due to a connection problem. I put the keep-branch label because it shares the same branch with #9.

This is actually a duplicate due to a connection problem. I put the `keep-branch` label because it shares the same branch with #9.

👍 1

MicheleC commented 4 years ago

Owner

Thanks Philippe, yes noticed the branch in common wiht #9

Thanks Philippe, yes noticed the branch in common wiht #9

MicheleC removed the

PR/keep-branch

label 4 years ago

MicheleC commented 4 years ago

Owner

PR #9 has been merged, so the keep branch tag is no longer required.

PR #9 has been merged, so the keep branch tag is no longer required.

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels   

GE/need-info

General - need additional info from contributor   

PR/keep-branch

Pull request - do not delete branch after merging   

PR/not-ok

Pull request - need fixing   

PR/rfc

Pull request - request for comments   

PR/update-trans

Pull request - update to translation files needed   

PR/wip

Pull request - work in progress   

RS/R14.0.x

Related to R14.0.x series   

RS/R14.1.x

Related to R14.1.x series   

SL/critical

Severity level - critical   

SL/major

Severity level - major   

SL/minor

Severity level - minor   

SL/normal

Severity level - normal   

SL/regression

Severity level - regression from previous version   

SL/trivial

Severity level - trivial   

SL/wishlist

Severity level - wishlist request   

ST/duplicate

Status - duplicate of another issue   

ST/invalid

Status - invalid report   

ST/notourproblem

Status - not our problem   

ST/rejected

Status - rejected   

ST/wontfix

Status - won't fix   

ST/worksforme

Status - works for me, unable to reproduce

No Label

GE/need-info

PR/keep-branch

PR/not-ok

PR/rfc

PR/update-trans

PR/wip

RS/R14.0.x

RS/R14.1.x

SL/critical

SL/major

SL/minor

SL/normal

SL/regression

SL/trivial

SL/wishlist

ST/duplicate

ST/invalid

ST/notourproblem

ST/rejected

ST/wontfix

ST/worksforme

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TDE/kompose#8

Write Preview

Loading…

Cancel

Save

There is no content yet.