Removed grubconfig and wineconfig modules plus some other unnecessary files #12

Merged
MicheleC merged 3 commits from drop/unused-modules into master 1 year ago
Owner

grubconfig was not being built for long time.
wineconfig was built but not packaged for about a year. wineconfig crashes at runtime and is outdated, therefore it is recommended to use the wine configuration GUI that comes with wine itself.

grubconfig was not being built for long time. wineconfig was built but not packaged for about a year. wineconfig crashes at runtime and is outdated, therefore it is recommended to use the wine configuration GUI that comes with wine itself.
MicheleC added this to the R14.1.2 release milestone 1 year ago
MicheleC added 1 commit 1 year ago
977a94737a
Removed grubconfig and wineconfig modules plus some other unnecessary files
Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
MicheleC requested review from Core 1 year ago
MicheleC requested review from Owners 1 year ago
SlavekB requested changes 1 year ago
SlavekB left a comment
Owner

For better clarity in history, I propose to do it as three separate commits:

  1. Removal of grubconfig
  2. Removal of wineconfig
  3. Removal of other unnecessary files.
    There is one note about the authors – see below.

The observations and ideas from review_guidance_malago.pdf are outdated or would it be good to keep the file so that thoughts can ever be incorporated?

For better clarity in history, I propose to do it as three separate commits: 1. Removal of grubconfig 2. Removal of wineconfig 3. Removal of other unnecessary files. There is one note about the authors – see below. The observations and ideas from `review_guidance_malago.pdf` are outdated or would it be good to keep the file so that thoughts can ever be incorporated?
@ -15,4 +0,0 @@
Simon Edwards <simon@simonzone.com>, SVN username: sedwards, IRC: sime (unregistered)
Sebastian Kügler <sebas@kde.nl>, SVN username: sebas, IRC: sebas
Yuriy Kozlov <yuriy.kozlov@gmail.com>, SVN username: ykozlov, IRC: yuriy
Martin Böhm <martin.bohm@kubuntu.org>, SVN username: martinbohm, IRC: ???
SlavekB commented 1 year ago
Owner

Would it be appropriate to move the original authors to the AUTHORS file?

Would it be appropriate to move the original authors to the AUTHORS file?
Poster
Owner

Good idea

Good idea
MicheleC marked this conversation as resolved
MicheleC force-pushed drop/unused-modules from 977a94737a to c3235821bc 1 year ago
Poster
Owner

PR updated based on feedback.

PR updated based on feedback.
MicheleC requested review from SlavekB 1 year ago
SlavekB approved these changes 1 year ago
SlavekB left a comment
Owner

It looks good.
It is necessary to verify the RPM packaging because wineconfig is currently included in these packages.

It looks good. It is necessary to verify the RPM packaging because wineconfig is currently included in these packages.
MicheleC merged commit c3235821bc into master 1 year ago
MicheleC deleted branch drop/unused-modules 1 year ago
Poster
Owner

@Francois
please take note of the removal of wineconfig and update RPM building instructions accordingly if needed. In debian wineconfig was not packed for almost a year, since it was crashing at runtime.

@Francois please take note of the removal of wineconfig and update RPM building instructions accordingly if needed. In debian wineconfig was not packed for almost a year, since it was crashing at runtime.

Reviewers

SlavekB approved these changes 1 year ago
TDE/Core was requested for review 1 year ago
The pull request has been merged as c3235821bc.
Sign in to join this conversation.
No reviewers
TDE/Core
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tde-guidance#12
Loading…
There is no content yet.