Conversion to cmake building system #13

kcm_module_stub.cpp.cmake is taken from pytdeextensions/src/tdedistutils.py, it's the stub code used to generate TDE control modules.
tde-guidance package location is detected based on the location of the python setuptools, to avoid hardcoding it.
python scripts enforced to python3.
desktop files prepared for further translation after autotools support is dropped.
added man pages from debian packaging repository.

1. kcm_module_stub.cpp.cmake is taken from pytdeextensions/src/tdedistutils.py, it's the stub code used to generate TDE control modules. 2. tde-guidance package location is detected based on the location of the python setuptools, to avoid hardcoding it. 3. python scripts enforced to python3. 4. desktop files prepared for further translation after autotools support is dropped. 5. added man pages from debian packaging repository.

It looks good. There are some notes to consider.

Originally I hesitated that if we want to change shebang to python3, but it is true that it does not matter – probably other supported distributions also provide such a binary name.

It looks good. There are some notes to consider. Originally I hesitated that if we want to change shebang to python3, but it is true that it does not matter – probably other supported distributions also provide such a binary name.

PR updated as per feedback and rebased.

I did a test on Debian 10 (Buster) and because I got FTBFS, I added a second commit to solve the problem. At the same time, I modified the detection of pythonize library to be detected as a library, instead of detection as a file. If you are satisfied with it, you can do squash because there is no need to be merged as two separate commits.

One more additional adjustment: Auxiliary python modules that are used as import <module> and are not called as separate commands do not need executable permission. That's why I moved the installation from PROGRAMS to FILES.

One more additional adjustment: Auxiliary python modules that are used as `import <module>` and are not called as separate commands do not need executable permission. That's why I moved the installation from `PROGRAMS` to `FILES`.

All looks good.

 @ -0,0 +53,4 @@
   OUTPUT_VARIABLE PYTHON_SETUP_TOOLS_DIR
   OUTPUT_STRIP_TRAILING_WHITESPACE
 )
 string( REGEX REPLACE "\\['(.*)'\\]" "\\1" PYTHON_SETUP_TOOLS_DIR2 ${PYTHON_SETUP_TOOLS_DIR} )

 @ -0,0 +31,4 @@
 unset( _MODULEDIR_       )
 unset( _EXTRAMODULE_     )
 unset( _MODULENAME_      )
 unset( _FACTORYFUNCTION_ )

 @ -0,0 +60,4 @@
 ##### other files
 tde_create_translated_desktop(
   SOURCE mountconfig.desktop

 @ -0,0 +82,4 @@
   link_${MODULE_NAME} ALL COMMAND ${CMAKE_COMMAND} -E create_symlink
   ${TDE_GUIDANCE_DIST_PKG_PATH}/${MODULE_NAME}.py ${CMAKE_CURRENT_BINARY_DIR}/${MODULE_NAME}
 )
 install(

 @ -0,0 +30,4 @@
 unset( _MODULEDIR_       )
 unset( _EXTRAMODULE_     )
 unset( _MODULENAME_      )
 unset( _FACTORYFUNCTION_ )

Labels Milestones

Conversion to cmake building system #13

Reviewers

 @ -0,0 +50,4 @@
 )
 install(
   PROGRAMS serviceconfig.py