TDE
/
tdenetwork
6
0
Fork 0
Code Issues 8 Pull Requests 2 Releases Wiki Activity

Labels Milestones

KRFB: additional keys entry with replacing old ones at achieving the limit #61

Open
roman wants to merge 1 commits from feat/krfb-newenterkeys into master
pull from: feat/krfb-newenterkeys
merge into: TDE:master
Conversation 1 Commits 1 Files Changed 2
roman commented 1 year ago
Collaborator

Signed-off-by: Roman Savochenko roman@home.home

Signed-off-by: Roman Savochenko <roman@home.home>
roman added the
SL/normal
 label 1 year ago
roman added 1 commit 1 year ago
MicheleC requested changes 1 year ago
MicheleC left a comment
Owner

Please get rid of the goto in the code. goto is bad practice (Dijkstra docet), so a patch with goto will not accepted

Please get rid of the `goto` in the code. `goto` is bad practice (Dijkstra docet), so a patch with `goto` will not accepted
roman commented 1 year ago
Poster
Collaborator

Please get rid of the goto in the code. goto is bad practice (Dijkstra docet), so a patch with goto will not accepted

That is normal practice if you don't want to cardinal change the present already code structure. And I am known in bad and not bad practice!

> Please get rid of the `goto` in the code. `goto` is bad practice (Dijkstra docet), so a patch with `goto` will not accepted That is normal practice if you don't want to cardinal change the present already code structure. And I am known in bad and not bad practice!

Reviewers

MicheleC requested changes 1 year ago
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
MicheleC
Labels
Apply labels
Clear labels   
GE/need-info

General - need additional info from contributor   
PR/keep-branch

Pull request - do not delete branch after merging   
PR/not-ok

Pull request - need fixing   
PR/rfc

Pull request - request for comments   
PR/update-trans

Pull request - update to translation files needed   
PR/wip

Pull request - work in progress   
RS/R14.0.x

Related to R14.0.x series   
RS/R14.1.x

Related to R14.1.x series   
SL/critical

Severity level - critical   
SL/major

Severity level - major   
SL/minor

Severity level - minor   
SL/normal

Severity level - normal   
SL/regression

Severity level - regression from previous version   
SL/trivial

Severity level - trivial   
SL/wishlist

Severity level - wishlist request   
ST/duplicate

Status - duplicate of another issue   
ST/invalid

Status - invalid report   
ST/notourproblem

Status - not our problem   
ST/rejected

Status - rejected   
ST/wontfix

Status - won't fix   
ST/worksforme

Status - works for me, unable to reproduce
No Label
GE/need-info
PR/keep-branch
PR/not-ok
PR/rfc
PR/update-trans
PR/wip
RS/R14.0.x
RS/R14.1.x
SL/critical
SL/major
SL/minor
SL/normal
SL/regression
SL/trivial
SL/wishlist
ST/duplicate
ST/invalid
ST/notourproblem
ST/rejected
ST/wontfix
ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Blocks
#24 krfb: Deleting the entered additional keys at achievement the limit and at exit
TDE/tdenetwork
#11 bug#3014: KRFB: The new function of registering-appending the new entered keys
TDE/tdenetwork
Reference: TDE/tdenetwork#61
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/krfb-newenterkeys'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes