Labels Milestones

Prevent creation of text codecs when the application is shutting down #143

Merged

MicheleC merged 1 commits from fix/issue/142 into master 11 months ago

Conversation 4 Commits 1 Files Changed 1

MicheleC commented 11 months ago

Owner

The fix is relatively simple. When the application shuts down, it will destroy all codecs by calling TQTextCodec::deleteAllCodecs(). The code will remember that this happened and will not setup the codecs again if this is requested after the initial deletion. The rest of the changes are mostly renames/cosmetics + some extra locks every time the list of codecs is modified.
This resolves issue #142.

The fix is relatively simple. When the application shuts down, it will destroy all codecs by calling `TQTextCodec::deleteAllCodecs()`. The code will remember that this happened and will not setup the codecs again if this is requested after the initial deletion. The rest of the changes are mostly renames/cosmetics + some extra locks every time the list of codecs is modified. This resolves issue #142.

MicheleC added this to the R14.1.2 release milestone 11 months ago

MicheleC requested review from Core 11 months ago

MicheleC requested review from Owners 11 months ago

MicheleC referenced this pull request 11 months ago

Regression caused by PR #127 #142

Fat-Zer commented 11 months ago

Collaborator

Hm... I don't really like that solution... I thought I were gonna make tqWarning() work rather than just print another message...

PS: And we definitely shouldn't use printf() for error reporting...

Hm... I don't really like that solution... I thought I were gonna make tqWarning() work rather than just print another message... PS: And we definitely shouldn't use `printf()` for error reporting...

Fat-Zer referenced this pull request 11 months ago

TQTextCodec: avoid dangling pointer to current locale's codec #144

Fat-Zer commented 11 months ago

Collaborator

I'd like to propose the alternative to this one: #144

I'd like to propose the alternative to this one: #144

MicheleC referenced this pull request 11 months ago

TQTextCodec: avoid dangling pointer to current locale's codec #144

MicheleC force-pushed fix/issue/142 from 157bc2b4ca to faabef99c0 11 months ago

MicheleC commented 11 months ago

Poster

Owner

Hm... I don't really like that solution... I thought I were gonna make tqWarning() work rather than just print another message...

PS: And we definitely shouldn't use printf() for error reporting...

See this comment on PR #144.

> Hm... I don't really like that solution... I thought I were gonna make tqWarning() work rather than just print another message... > > PS: And we definitely shouldn't use `printf()` for error reporting... See [this comment](https://mirror.git.trinitydesktop.org/gitea/TDE/tqt3/pulls/144#issuecomment-48883) on PR #144.

MicheleC commented 11 months ago

Poster

Owner

PR updated with additional comments for printf and explicit setting of localeMapper = 0 (see discussion on PR #144).

PR updated with additional comments for `printf` and explicit setting of `localeMapper = 0` (see discussion on PR #144).

SlavekB referenced this pull request 11 months ago

TQTextCodec: avoid dangling pointer to current locale's codec #144

SlavekB approved these changes 11 months ago

SlavekB left a comment

Owner

LGTM

LGTM

MicheleC force-pushed fix/issue/142 from faabef99c0 to 7563c4825f 11 months ago

MicheleC merged commit 7563c4825f into master 11 months ago

MicheleC deleted branch fix/issue/142 11 months ago

MicheleC referenced this pull request 11 months ago

TQTextCodec: avoid dangling pointer to current locale's codec #144

MicheleC referenced this pull request 11 months ago

Various memory leak and other fixes for R14.1.2 [meta issue] #130

MicheleC referenced this pull request 11 months ago

Regression caused by PR #127 #142

Reviewers

SlavekB approved these changes 11 months ago

TDE/Core was requested for review 11 months ago

The pull request has been merged as 7563c4825f.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

SlavekB

TDE/Core

Labels

Apply labels

Clear labels   

GE/need-info

General - need additional info from contributor   

PR/keep-branch

Pull request - do not delete branch after merging   

PR/not-ok

Pull request - need fixing   

PR/rfc

Pull request - request for comments   

PR/update-trans

Pull request - update to translation files needed   

PR/wip

Pull request - work in progress   

RS/R14.0.x

Related to R14.0.x series   

RS/R14.1.x

Related to R14.1.x series   

SL/critical

Severity level - critical   

SL/major

Severity level - major   

SL/minor

Severity level - minor   

SL/normal

Severity level - normal   

SL/regression

Severity level - regression from previous version   

SL/trivial

Severity level - trivial   

SL/wishlist

Severity level - wishlist request   

ST/duplicate

Status - duplicate of another issue   

ST/invalid

Status - invalid report   

ST/notourproblem

Status - not our problem   

ST/rejected

Status - rejected   

ST/wontfix

Status - won't fix   

ST/worksforme

Status - works for me, unable to reproduce

No Label

GE/need-info

PR/keep-branch

PR/not-ok

PR/rfc

PR/update-trans

PR/wip

RS/R14.0.x

RS/R14.1.x

SL/critical

SL/major

SL/minor

SL/normal

SL/regression

SL/trivial

SL/wishlist

ST/duplicate

ST/invalid

ST/notourproblem

ST/rejected

ST/wontfix

ST/worksforme

Milestone

Set milestone

Clear milestone

No items

No Milestone

R14.1.2 release

Assignees

Assign users

Clear assignees

No Assignees

3 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tqt3#143

Write Preview

Loading…

Cancel

Save

There is no content yet.