TDE
/
tdepowersave
6
0
Fork 0
Code Issues 2 Pull Requests 1 Releases Wiki Activity

Labels Milestones

Removed HAL dependant code. #9

Merged
MicheleC merged 1 commits from drop/hal-code into master 3 years ago
Conversation 1 Commits 1 Files Changed 58
MicheleC commented 3 years ago
Owner

Cleanup of HAL left over code and comments.

Cleanup of HAL left over code and comments.
MicheleC added this to the R14.1.0 release milestone 3 years ago
MicheleC added 1 commit 3 years ago
c1a94699ce
Removed HAL dependant code. 
Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
SlavekB requested changes 3 years ago
SlavekB left a comment
Owner

Instead of removing config.h, it should have better content. At the same time, it should be used in CPP files instead of in H.

Instead of removing config.h, it should have better content. At the same time, it should be used in CPP files instead of in H.
CMakeLists.txt Outdated
@ -68,4 +67,0 @@
##### write configure files #####################
configure_file( config.h.cmake config.h @ONLY )
SlavekB commented 3 years ago
Owner

Instead of removing, we probably should do at least ordinary config.h.

Instead of removing, we probably should do at least ordinary `config.h`.
MicheleC marked this conversation as resolved
config.h.cmake Outdated
@ -1 +0,0 @@
#cmakedefine HAVE_HAL_0_5_10 1
SlavekB commented 3 years ago
Owner

I suggest using the usual basic content instead of removal:

#define VERSION "@VERSION@"

// Defined if you have fvisibility and fvisibility-inlines-hidden support.
#cmakedefine __KDE_HAVE_GCC_VISIBILITY 1

/* Define WORDS_BIGENDIAN to 1 if your processor stores words with the most
   significant byte first (like Motorola and SPARC, unlike Intel). */
#cmakedefine WORDS_BIGENDIAN @WORDS_BIGENDIAN@
I suggest using the usual basic content instead of removal: ``` #define VERSION "@VERSION@" // Defined if you have fvisibility and fvisibility-inlines-hidden support. #cmakedefine __KDE_HAVE_GCC_VISIBILITY 1 /* Define WORDS_BIGENDIAN to 1 if your processor stores words with the most significant byte first (like Motorola and SPARC, unlike Intel). */ #cmakedefine WORDS_BIGENDIAN @WORDS_BIGENDIAN@ ```
MicheleC marked this conversation as resolved
src/dbusInterface.h Outdated
@ -37,4 +37,1 @@
// Global Header
#ifdef HAVE_CONFIG_H
#include <config.h>
SlavekB commented 3 years ago
Owner

Including config.h probably should be moved to CPP files.

Including `config.h` probably should be moved to CPP files.
MicheleC marked this conversation as resolved
src/hardware.cpp Outdated
@ -1087,1 +1079,3 @@
// blocked by normal KDE/QT (GUI) calls
// need this functions to make events independent
// from Qt event loop and to allow TQt3 D-Bus bindings to get not
// blocked by normal TDE/QT (GUI) calls
SlavekB commented 3 years ago
Owner

At the same time, replace Qt => TQt.

At the same time, replace Qt => TQt.
MicheleC marked this conversation as resolved
src/hardware.h Outdated
@ -35,4 +35,1 @@
// Global Header
#ifdef HAVE_CONFIG_H
#include <config.h>
SlavekB commented 3 years ago
Owner

Including config.h probably should be moved to CPP files.

Including `config.h` probably should be moved to CPP files.
MicheleC marked this conversation as resolved
src/hardware_battery.h Outdated
@ -34,4 +34,1 @@
// Global Header
#ifdef HAVE_CONFIG_H
#include <config.h>
SlavekB commented 3 years ago
Owner

Including config.h probably should be moved to CPP files.

Including `config.h` probably should be moved to CPP files.
MicheleC marked this conversation as resolved
src/hardware_batteryCollection.h Outdated
@ -33,4 +33,1 @@
// Global Header
#ifdef HAVE_CONFIG_H
#include <config.h>
SlavekB commented 3 years ago
Owner

Including config.h probably should be moved to CPP files.

Including `config.h` probably should be moved to CPP files.
MicheleC marked this conversation as resolved
src/hardware_cpu.h Outdated
@ -35,4 +35,1 @@
// Global Header
#ifdef HAVE_CONFIG_H
#include <config.h>
SlavekB commented 3 years ago
Owner

Including config.h probably should be moved to CPP files.

Including `config.h` probably should be moved to CPP files.
MicheleC marked this conversation as resolved
src/tdepowersave.h Outdated
@ -24,4 +24,1 @@
// Global Header
#ifdef HAVE_CONFIG_H
#include <config.h>
SlavekB commented 3 years ago
Owner

Including config.h probably should be moved to CPP files.

Including `config.h` probably should be moved to CPP files.
MicheleC marked this conversation as resolved
src/tdepowersave_debug.h Outdated
@ -23,4 +23,1 @@
// Global Header
#ifdef HAVE_CONFIG_H
#include <config.h>
SlavekB commented 3 years ago
Owner

Including config.h probably should be moved to CPP files.

Including `config.h` probably should be moved to CPP files.
MicheleC marked this conversation as resolved
MicheleC force-pushed drop/hal-code from c1a94699ce to 4112c3b486 3 years ago
MicheleC commented 3 years ago
Poster
Owner

I have updated the PR as per suggested feedback. Please take another look.

I have updated the PR as per suggested feedback. Please take another look.
SlavekB approved these changes 3 years ago
SlavekB left a comment
Owner

Tested, looks good.

Tested, looks good.
MicheleC merged commit 4112c3b486 into master 3 years ago
MicheleC deleted branch drop/hal-code 3 years ago

Reviewers

SlavekB approved these changes 3 years ago
The pull request has been merged as 4112c3b486.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
SlavekB
Labels
Apply labels
Clear labels   
GE/need-info

General - need additional info from contributor   
PR/keep-branch

Pull request - do not delete branch after merging   
PR/not-ok

Pull request - need fixing   
PR/rfc

Pull request - request for comments   
PR/update-trans

Pull request - update to translation files needed   
PR/wip

Pull request - work in progress   
RS/R14.0.x

Related to R14.0.x series   
RS/R14.1.x

Related to R14.1.x series   
SL/critical

Severity level - critical   
SL/major

Severity level - major   
SL/minor

Severity level - minor   
SL/normal

Severity level - normal   
SL/regression

Severity level - regression from previous version   
SL/trivial

Severity level - trivial   
SL/wishlist

Severity level - wishlist request   
ST/duplicate

Status - duplicate of another issue   
ST/invalid

Status - invalid report   
ST/notourproblem

Status - not our problem   
ST/rejected

Status - rejected   
ST/wontfix

Status - won't fix   
ST/worksforme

Status - works for me, unable to reproduce
No Label
GE/need-info
PR/keep-branch
PR/not-ok
PR/rfc
PR/update-trans
PR/wip
RS/R14.0.x
RS/R14.1.x
SL/critical
SL/major
SL/minor
SL/normal
SL/regression
SL/trivial
SL/wishlist
ST/duplicate
ST/invalid
ST/notourproblem
ST/rejected
ST/wontfix
ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.1.0 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdepowersave#9
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'drop/hal-code'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes